Skip to content

refactor(sonar): fix sonar warnings#217

Merged
ReenigneArcher merged 2 commits into
masterfrom
refactor/sonar/fix-sonar-warnings
Jun 22, 2026
Merged

refactor(sonar): fix sonar warnings#217
ReenigneArcher merged 2 commits into
masterfrom
refactor/sonar/fix-sonar-warnings

Conversation

@ReenigneArcher

@ReenigneArcher ReenigneArcher commented Jun 22, 2026

Copy link
Copy Markdown
Member

Description

Fixes sonar warnings.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@codecov

codecov Bot commented Jun 22, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 71.42857% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.04%. Comparing base (0d22dc6) to head (aa58d39).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/ui/host_probe_result_queue.cpp 66.66% 4 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #217      +/-   ##
==========================================
+ Coverage   63.02%   63.04%   +0.02%     
==========================================
  Files          32       33       +1     
  Lines        5239     5242       +3     
  Branches     2386     2386              
==========================================
+ Hits         3302     3305       +3     
- Misses        934     1112     +178     
+ Partials     1003      825     -178
Flag Coverage Δ
Linux 63.36% <68.42%> (+<0.01%) ⬆️
macOS 49.98% <66.66%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/network/host_discovery.cpp 91.42% <ø> (ø)
src/ui/host_probe_result_queue.h 100.00% <100.00%> (ø)
src/ui/host_probe_result_queue.cpp 52.77% <66.66%> (ø)

... and 14 files with indirect coverage changes

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d22dc6...aa58d39. Read the comment docs.

@ReenigneArcher ReenigneArcher force-pushed the refactor/sonar/fix-sonar-warnings branch from f046975 to b22b192 Compare June 22, 2026 17:46
@ReenigneArcher ReenigneArcher force-pushed the refactor/sonar/fix-sonar-warnings branch from b22b192 to aa58d39 Compare June 22, 2026 17:56
@ReenigneArcher ReenigneArcher merged commit 3243c05 into master Jun 22, 2026
17 checks passed
@ReenigneArcher ReenigneArcher deleted the refactor/sonar/fix-sonar-warnings branch June 22, 2026 18:22
@sonarqubecloud

sonarqubecloud Bot commented Jun 22, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ReenigneArcher